We need to move away from this hardcoded array
and toward something more configurable.

As a transition step, let's allow the
configurable option list to override the array.

Fix #3185

This is probably such a little-used feature that no one ever noticed it was broken.
And since the entityFile and File tables are usually the same size, it might have (accidentally) worked correctly most of the time.
But the wrong id was being used.

#5716 Fix Regression with CheckBox custom fields not respecting the options per line setting

In 9d4c4ffd a hook was added to automatically
delete entityTag records when the parent record was deleted.
However there was still some redundant coupling hanging around, so
I removed it and added a test to ensure it wasn't needed.

Some codepaths were setting this and others were not.

For feature parity with Api3 Attachment,
now Api4 File can get and set file contents,
and move temp files.

This also enables Api4 to fetch file info from custom
fields via joins.

Usage was all over the place, but I checked and these
settings will always have a trailing slash due to the 'setting-path' property in MagicMerge.

The `EntityFile` table serves 2 purposes:

1. As a many-to-many bridge table for entities that support multiple attachments
2. As a redundant copy of the value of custom fields of type File

The 2nd use is problematic and it would be good to eliminate these redundant
records.

This chips away at the problem by removing the need for an entry in the
EntityFile table in order to create a link to the file.

Given a MembershipID get the latest ContributionID from the lineItem first and only fallback to MembershipPayment if not found via lineItem

When deleting something that's the criteria for a custom group
(e.g. an activity type, event type, event, financial type, etc)
this will clean up stale references so the custom group no longer
points to entities that don't exist.
If the deleted thing is the last reference, the custom group will
be disabled, as otherwise the empty set would be interpreted as "all".

Fixes #5749

Now that Api4 directly supports contact types as entities,
this workaround is not needed.

Fixes #5747

Updates code to use preferred newer PHP function

Updates code to use preferred newer PHP function

Replaced lengthy `isset` conditions with the more concise null coalescing operator.

The `empty()` function will automatically handle the case where the first part
of the expression is not set, so there's no need to add an extra call to `empty()`.

Fixes #4923

Now that the last 2 domain-specific option groups have been dealt with:

- https://github.com/civicrm/civicrm-core/pull/31909
- https://github.com/civicrm/civicrm-core/pull/31924

... we can stop using this godawful is_domain column for good.
The OptionValue table is complex enough without it!

A few forms present a dropdown for "From Email Address",
and most of them were not correctly setting the default.
I investigated and found a couple causes:

1. Some forms just didn't bother to set it
2. Some forms *tried* to set it, but it got mangled by the html purifier

For the not-even-trying forms, a pretty simple catch-all solution is to
put the default at the top of the list, thus the change to CRM_Core_BAO_Email::domainEmails

For the ones that were trying and failing, I added the field to
getFieldsToExcludeFromPurification.

Consistently use "Site Email Addresses" instead of "FROM Email Addresses"
(and no need to SHOUT).

Deprecated the `returnFormatted` parameter in `getNameAndEmail` and updated relevant code to align with the new method.

Also removed unnecessary domain filtering logic from OptionValue as this was the only option group it applied to.

Replaced legacy "from_email_address" option group references with the new API.

bgm authored 2 months ago and bgm committed 2 months ago

It is not clear what is the purpose of the check and it can fail
mysteriously. See also extensions/fixoptiontranslations#5

Before: create a custom field with maxlength > 2000
and check the Optimize for Search option.
The result is a fatal error.

After: Field is created without issue.

Updated `fieldToSQLType` to handle Link fields with a default maxLength of 2047, reflecting sitemap URL limits. Adjusted tests to validate handling of Link fields.

Fixes #5698

This regressed with 9d46d484