api3 contact.getoptions for custom fields either returns null or an error

This PR https://github.com/civicrm/civicrm-core/pull/31968/files added some legacy handling, but in the case of custom fields it's now passing on an api4-formatted fieldname instead of the api3 "custom_NN" format. Then when it hits the pseudoconstant it doesn't match.

It actually hasn't been working since 5.79-ish, but now since 5.82 with that PR it can introduce an error if it returns false, which api3 thinks is a fail.

added regression label

Does this help? https://github.com/civicrm/civicrm-core/pull/32167

A pull request related to this issue has been opened with the title: #5747 (closed) - unit test for failing getoptions with custom field

mentioned in commit 64d770df

A pull request related to this issue has been opened with the title: #5747 (closed) - Fix getting options from disabled custom fields

A pull request related to this issue has been opened with the title: #5747 (closed) - backport - Getoptions should use legacy fieldName for legacy handling

mentioned in commit c7bdfd8a

mentioned in commit 8e389860

mentioned in commit d7fffcca

mentioned in commit 6b2eb069

mentioned in commit 9fc0a1b5

closed with commit 6b2eb069

changed milestone to %5.82.1