- Oct 02, 2020
-
-
Seamus Lee authored
#2057 Remove extraneous activity contact queries on activity update
-
Seamus Lee authored
Fix cache bypass
-
- Oct 01, 2020
-
-
Eileen McNaughton authored
#2079 [REF] Remove reference to second param returned from CRM_Contact_BAO_Query::apiQuery
-
Seamus Lee authored
#2046 Ensure location BAOs have create actions, deprecate add…
-
Seamus Lee authored
[REF] Follow up cleanup from Event Location
-
eileen authored
-
Eileen McNaughton authored
#2079 [REF] Fix some more calls to getTokens to make it clear only the first return value is used
-
Seamus Lee authored
Fix patently silly code
-
eileen authored
This changes it so that instead of doing either 1) if passing in an array of activity contacts for a given type then attempt to delete existing contacts, regardless of whether they are the same as the existing ones, create new ones OR 2) if the param is an int then do a lookup, per record type, and update if needed to - Do one query to find existing records of types to be deleted (for all 3 record types). Only delete activity contact records that are not to be kept and don't alter those records that should be retained
-
eileen authored
-
eileen authored
-
eileen authored
-
eileen authored
If the contact is not impacted by any acls then ids will be an empty array. However, currently an empty array is treated as 'uncached' rather than 'cached by empty' which would be represented by null
-
Seamus Lee authored
#2073 Improve cleanup on syntax conformance test
-
Eileen McNaughton authored
#2003 Use Brick/Money to ensure that we display all possible …
-
Seamus Lee authored
(REF) Switch to composer-compile-lib
-
eileen authored
Cleaning up all objects seems a bit too much - but ensuring we re-set the DAO we create in this class should be a memory-friendly action https://github.com/civicrm/civicrm-core/pull/18639
-
- Sep 30, 2020
-
-
totten authored
-
Seamus Lee authored
#2046 Rationalise add vs create on website BAO
-
Seamus Lee authored
#334 Use the current in use collation and character sets when…
-
totten authored
The overall effect of this change is to get access to a few more helpers. Before: Load `composer-compile-plugin`, `scssphp`, and `php-autoprefxer` as three distinct packages. After: Load `composer-compile-lib`, which transitively requires all those others *and* includes some helpers. Sea also * https://github.com/civicrm/composer-compile-plugin * https://github.com/civicrm/composer-compile-lib
-
Seamus Lee authored
#2003 Use Brick/Money to ensure that we display all possible digits stored in the database for the option amount Add in noisy notice about fall back due to missing intl extension
-
Seamus Lee authored
membership#27 Update outdated membership statuses in preProcess rather than submit
-
Seamus Lee authored
#2073 Memory drain
-
Seamus Lee authored
#334 Use the current in use collation and character sets when creating new custom value tables
-
Seamus Lee authored
[REF] Add in frontend fields for title and description of group Schem…
-
Seamus Lee authored
Add in upgrade step to expand title column to be 255 as well Update langauge as per Artfulrobot and require group title field
-
Seamus Lee authored
#2073 Fix a real live leak
-
eileen authored
I used the same methods I had been playing with on the test class on a contribution import script and found that the object that was increasing in memory in tandem with me increasing iterations was an instance of DB_result I tracked it down to here. In essence our main DAO functions clean up after themselves - e.g when the DAO is destructed it cleans up the globals it has created. However, this older ->query() function does not do that and each time is is called increases it's memory hold. It's also worth better caching in this function...
-
Seamus Lee authored
[Civi\Test] Fix test output noise
-
Eileen McNaughton authored
#2075 - E_NOTICE viewing an activity that has no details contents
-
eileen authored
Seeing this is test logs Warning: Invalid argument supplied for foreach() in /home/jenkins/bknix-dfl/build/core-18634-8zcf7/web/sites/all/modules/civicrm/Civi/Test/Schema.php on line 29 Call Stack: 0.0007 530944 1. {main}() /home/jenkins/bknix-dfl/extern/phpunit7/phpunit7.phar:0 0.0498 9999808 2. PHPUnit\TextUI\Command::main() /home/jenkins/bknix-dfl/extern/phpunit7/phpunit7.phar:615 0.0498 10008600 3. PHPUnit\TextUI\Command->run() phar:///home/jenkins/bknix-dfl/extern/phpunit7/phpunit7.phar/phpunit/TextUI/Command.php:162 1.1684 104654872 4. PHPUnit\TextUI\TestRunner->doRun() phar:///home/jenkins/bknix-dfl/extern/phpunit7/phpunit7.phar/phpunit/TextUI/Command.php:206 1.2327 104791840 5. PHPUnit\Framework\TestSuite->run() phar:///home/jenkins/bknix-dfl/extern/phpunit7/phpunit7.phar/phpunit/TextUI/TestRunner.php:652 3300.8182 675188928 6. PHPUnit\Framework\TestSuite->run() phar:///home/jenkins/bknix-dfl/extern/phpunit7/phpunit7.phar/phpunit/Framework/TestSuite.php:746 3300.8199 675188928 7. CiviUnitTestCase::setUpBeforeClass() phar:///home/jenkins/bknix-dfl/extern/phpunit7/phpunit7.phar/phpunit/Framework/TestSuite.php:703 3300.8199 675188928 8. CiviUnitTestCase::_populateDB() /home/jenkins/bknix-dfl/build/core-18634-8zcf7/web/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php:311 3300.8199 675188928 9. Civi\Test\Data->populate() /home/jenkins/bknix-dfl/build/core-18634-8zcf7/web/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php:305 3300.8199 675189248 10. Civi\Test::asPreInstall() /home/jenkins/bknix-dfl/build/core-18634-8zcf7/web/sites/all/modules/civicrm/Civi/Test/Data.php:45 :
-
- Sep 29, 2020
-
-
DaveD authored
-
Eileen McNaughton authored
#2063: Don't throw a warning when public ext directory isn't found
-
Eileen McNaughton authored
#1838 Ensure that no fatal error is triggered if you try to a…
-
Eileen McNaughton authored
Set participant status notification to false by default
-
Seamus Lee authored
#1838 Ensure that no fatal error is triggered if you try to access a merged contact and the contact that it was merged into has been permanently deleted Move exception capturing into the page layer and extend unit test to cover page function Update status message as per Mikeý's comment
-
Seamus Lee authored
#2073 just tweak a memory leak
-
eileen authored
-
eileen authored
This one is like https://github.com/civicrm/civicrm-core/pull/18632 but only seems to have switched us from an xml leakage to a string leakage - it still seems slightly better from a code quality point of view
-