Skip to content
Snippets Groups Projects
Commit 708fb7a2 authored by eileen's avatar eileen
Browse files

#2073 just tweak a memory leak

This one is like https://github.com/civicrm/civicrm-core/pull/18632 but only
seems to have switched us from an xml leakage to a string leakage - it still
seems slightly better from a code quality point of view
parent 4fc8726b
No related branches found
No related tags found
No related merge requests found
......@@ -5,6 +5,10 @@
*/
class CRM_Core_CodeGen_Main {
public $buildVersion;
/**
* @var string
*/
public $db_version;
/**
* drupal, joomla, wordpress
......@@ -76,11 +80,11 @@ class CRM_Core_CodeGen_Main {
$versionFile = $this->phpCodePath . "/xml/version.xml";
$versionXML = CRM_Core_CodeGen_Util_Xml::parse($versionFile);
$this->db_version = $versionXML->version_no;
$this->db_version = (string) $versionXML->version_no;
$this->buildVersion = preg_replace('/^(\d{1,2}\.\d{1,2})\.(\d{1,2}|\w{4,7})$/i', '$1', $this->db_version);
if (isset($argVersion)) {
// change the version to that explicitly passed, if any
$this->db_version = $argVersion;
$this->db_version = (string) $argVersion;
}
$this->schemaPath = $schemaPath;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment