[REF] Include contributioncancelactions extension in dismaker and reg…

#927 Remove code to update recur on cancel & fail where there is no recur

[REF] Extract handling for loading contribution recur object.

5.31

(NFC) #2029 - Make assertions in PrevNextTest more skimmable

#2115 Move some more financialacl code to a hook within the extension

Overview
--------

The test appears to have a random failure. Making it more readable may help figure out why.

Before
------

`testDeleteByCacheKey()` and the related `testFillArray()` both have some assertions in these two forms:

```
// Form #1, more verbose
$all = ...getSelections($cacheKey, $action);
$this->assertEquals([...expected...], array_keys($all)...);

// Form #2, more pithy
$this->assertSelections([...expected...], $action, $cacheKey);
```

After
-----

The verbose form is replaced with the pithier form.

In the pithier form, some of the default inputs are made explicit.

Comment
-------

It is confusing that the method `getSelections()` has a parameter `$action`
which can be `get` or `getall` -- and that `getall` does not (in fact) return
selections.  It returns all!  (The fact that the contract is weird makes the
unit-test helpful imho...)

financial#152 move code only relevant to repeattransaction into that function

#927 Enable contribution cancel actions extension

release-notes/5.30.1.md

Rationalise date formatting

Once completed this extension will be unhidden and available to disable

SavedSearch: add UI_name index to upgrade script

Per https://github.com/civicrm/civicrm-core/pull/18814 I dug into this addRecurSoftCredits and
it simply copies soft credits from the first transaction in the series to the new one. As such
it belongs in repeattransaction not the main body of completeOrder

I've been racking my brains as to why we do this and it just feels like copy & paste that has survived forever

This code is called only from the 2 PaypalIPN classes. In both cases the classes follow the same flow - ie

if the payment is part of a recurring series, then call recur
if the payment is NOT the first in the series then call repeattransaction
only proceed to the 'single' function if we are confirming the
first recurring payment or it is not recurring

This means the cancelled & failed functions can only be reached when the flow is not
recurring OR the payment is the first - in neither case does it make sense to copy date
from one payment in the series to others - I'm pretty sure this precedes many many code changes

#927 add first test on cancel 

Update CRM_Utils_Constant::value to support env variables

Declare support for cancelRecurring in manual processor

I made a small change to support the test - causing Membership.create not to set the
stattus_id if it is specified.

Remove always-true IF

#927 Add shell extension to move contribution cancel actions into

This came out of discovering a place in the code was 'accidentally formatted correctly'
and finding it far too hard to figure out the right way to specify the date formatting -
something that seems confirmed by finding various places with hard-coded date formattin
rather than using the setting

SavedSearch - Add name and label columns

This is something I discussed with @totten earlier but as the rc was being cut at the time
we went for the more conservative approach of only adding env support to thhe debug_query
function.  This extends to all defines - meaning they can be defined at the script level e.

env CIVICRM_DEBUG_LOG_QUERY=backtrace drush cvapi

(that already works)

Display public title and description on profiles and unsubscribe/subs…

Reviewer's partial from https://github.com/civicrm/civicrm-core/pull/18196

As can be seen by searching for calls to recurLinks recurID is not
an optional parameter for the call - so the IF is extraneous.

I've updated almost all the places that call it to
pass strict-type-casted int (or in one place ensured it already is)
as a bit of 'tightening'

Remove always true if

5.31.0 release notes initial run

Since paymentProcessorObj is loaded as the manual processor where another does not exist
the processor condition is always true - so this if is obsolete

Add test for recurring links and clean up method of retrieving recurring

Replace BAO calls with api calls in test class

Switch to calling api

Switch to calling the api