Skip to content
Snippets Groups Projects
New look: Off

finish 'this round' of completeOrder cleanup

    • Closed Issue created by eileen @eileen

    @mattwire & I have done a big round of cleanup on completeOrder - I think this round is almost at a close - I just wanted to add a gl to track what would get us to the end of 'this round'. I have a couple of related PRS open - but they are not clearly tied to it.

    So my definition of 'done' for this round is that now that we have have cleaned up how completeOrder deals with payment_processor_id (solely as an input param)

    1. we should ensure this cleanup gets back to the places calling it ie the api - which I think may be done and the 3 IPN classes. I'm pretty sure the task no longer passes this in. Getting it done before we close out this round means we won't have to go through the 'what is this required for' next time.
    2. we should only pass [$contribution] as objects (or pass $contribution instead of objects)
    3. we should close or merge this - https://github.com/civicrm/civicrm-core/pull/18527 - but if the latter we need to find a way we don't legitimise the nicely named variable or make it so next round it's hard to be sure that the only place it's called from is the Task form (we could also do that conversion this round)

    Cleaning it up out of the IPN classes is pretty simple - just a series of small changes as they are all well tested. Currently open are

    https://github.com/civicrm/civicrm-core/pull/18631 https://github.com/civicrm/civicrm-core/pull/18629

    Edited
    To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information

    Child items 0

    • No child items are currently assigned. Use child items to break down this issue into smaller parts.

    Activity

    Please register or sign in to reply