Display Inbound Email: linefeed suppressed

In order to verify this issue, an inbound email activity has to be created. Since this is difficult on the testing environment, I prepared the input for the API Explorer:

values: "id": "XXX",

        "activity_type_id": "12",

        "subject": "test",

        "activity_date_time": "2018-02-08 10:21:00",

        "details":

-ALTERNATIVE ITEM 0-

Das ist ein Test

  * Bullet 1
  * Bullet 2


 1. Number 1
 2. Number 2

Abschluss

-- 
Detlev Sieber
Mail: detlev.sieber@t-online.de


-ALTERNATIVE ITEM 1-

<html>
  <head>

    <meta http-equiv="content-type" content="text/html; charset=utf-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <p>Das ist ein Test</p>
    <ul>
      <li>Bullet 1</li>
      <li>Bullet 2</li>
    </ul>
    <p><br>
    </p>
    <ol>
      <li>Number 1</li>
      <li>Number 2</li>
    </ol>
    <p>Abschluss</p>
    <pre class="moz-signature" cols="72">-- 
Detlev Sieber
Mail: <a class="moz-txt-link-abbreviated" href="mailto:detlev.sieber@t-online.de">detlev.sieber@t-online.de</a>

</pre>
  </body>
</html>

-ALTERNATIVE END-

        "status_id": "2",

        "source_contact_id": "XXX"

@bgm I can't seem to close this now

Cross-reference: https://github.com/civicrm/civicrm-core/pull/11661

@eileen I added you as a 'developer' on the dev-team. It should give you more permissions for managing issues.

closed

changed milestone to %4.7.31

mentioned in issue #36 (closed)

mentioned in issue #65 (closed)

mentioned in commit 65970572

As pointed out by @jitendrapurohit on the GitHub PR (here), I can confirm HTML-containing content being cluttered with <br> tags due to that additional Smarty filter. Stepping through the code, I would say the nl2br filter should not be necessary in the first place, because non-HTML content is being tampered with in HTML_QuickForm_textarea::getFrozenHtml() already:

$value = htmlspecialchars($this->getValue());
if ($this->getAttribute('wrap') == 'off') {
  $html = $this->_getTabs() . '<pre>' . $value."</pre>\n";
} else {
  $html = nl2br($value)."\n";
}

For elements containing "wysiwyg" in their class attribute, this rendered value is then replaced with the raw value again in CRM_Core_Form_Renderer::elementToArray():

if ($el['type'] == 'textarea' && isset($element->_attributes['class']) && strstr($element->_attributes['class'], 'wysiwyg')) {
  $el['html'] = '<span class="crm-frozen-field">' . $el['value'] . '</span>';
}
else {
  $el['html'] = '<span class="crm-frozen-field">' . $el['html'] . '</span>';
}

The original problem should be fixed within that code path, and not the template file. Filtering everything through nl2br in the template is much too generic an assumption.

mentioned in commit 15df34f4

mentioned in issue #58 (closed)

mentioned in issue #336 (closed)

mentioned in issue #339 (closed)

mentioned in issue #365 (closed)

mentioned in issue #379 (closed)

@jensschuppe For the extra nl2br happening, I opened a new issue: #379 (closed)

added Concept approved sig:bug triaged labels

mentioned in issue #512 (closed)

Display Inbound Email: linefeed suppressed

Child items 0

Activity