Incorrect Form Validation for checkboxes on profiles

Civi 5.28.3, mjwshared 0.8.1, firewall 1.1, sweetalert 1.3

Event Form, profile in use has 1 required field of type checkbox.

If you check none - validation error- OK, Check All - no validation error.

Check 1 Validation error and stripe highlights all options not check and sweetalert displays a message to complete required fields. Switch to another processor, no issues.

added bug label

@kcristiano Thanks for reporting. Can you confirm a few things please..

• Which stripe version? 6.4.2?
• Is this a new issue with 5.28 (ie. was working ok on earlier versions of CiviCRM)?
• Would you be able to test with 6.5 branch of Stripe + mjwshared 0.9.2 (master branch)? I think the behaviour will be identical.

changed milestone to %6.5

@mattwire yes 6.4.2

This is a new stripe install, but have not seen on other existing sites.

I can look at testing, not much funding on this project, but I can do it on a copy. Based on what you think 6.5 will just confirm the issue still exists, correct?

@mattwire same behavior (incorect validation error) on Stripe 6.5 branch along with mjwshared 0.9.2

@kcristiano Thanks, that's what I expected. I suspect this is probably related to jquery validation changes (improvements) that went into CiviCRM core for 5.28+ so it would be good to see if the issue persists on older versions. Try commenting out these lines: https://lab.civicrm.org/extensions/stripe/-/blob/6.5/js/civicrm_stripe.js#L93-98

I've not tested that yet (there are so many combinations of form presentation..) but in theory that should not be required if CiviCRM is generated the "correct" form elements.

I've commented out those lines, flushed all caches and still get the same error. I evenn restarted all service, still getting validation error.

I am seeing this too. I have to make the checkbox field optional to allow the contribution form to work.

added Needs funding label

I made a change to use a Price Set checkbox and that allows payments to go through no issues. At least in my quick initial test. So the error was with a checkbox custom field for the partipant in a profile. Not sure it helps, but definitely interesting.

changed title from Incorrect Form Validation to Incorrect Form Validation for checkboxes on profiles

mentioned in commit 9e43416b

@danaskallman @andyburns @kcristiano Can you please test 9e43416b (or latest 6.5 branch)

mentioned in issue #235 (closed)

mentioned in commit fefb07c1

closed with merge request !124 (merged)

closed with commit fefb07c1

@mattwire This issue still persist when we include the checkbox fields in "onbehalf of org" profile. Here is my attempt to fix based on the current logic. patch.txt

However, one problem I have noticed that it shows required only for the first checkbox field if there are multiple checkbox fields in the profile.

Note that it is working fine when we have multiple checkbox fields in the normal profile. Any help is appreciated.

Hello @mattwire

Any thoughts on the above? Thank you.

mentioned in issue #298 (closed)

mentioned in merge request !144 (merged)

mentioned in issue #364 (closed)

mentioned in merge request mjwshared!39 (merged)

@mattwire This problem appears for me, as described in OP, and @JonGold 's PR mjwshared!39 (merged) resolves it.

CiviCRM: 5.78.4 Stripe: 6.11.3 Payment Shared: 1.3.2

I recommend taking that PR. I'll also add some code-related comments in that PR.

reopened