Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • F form-processor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 16
    • Issues 16
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Extensions
  • form-processor
  • Merge requests
  • !35

improved boolean type

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged JonGold requested to merge JonGold/form-processor:improved-booleans into master Apr 21, 2022
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 2

Currently, the "Yes/No" input type can't take the values "Yes" or "No". Or "True", TRUE, "False", or FALSE. It can only take 1 and 0.

This is a drop-in replacement to correct that - any value defined as a valid "Boolean" value in CRM_Utils_Rule::boolean() is accepted now. Because this is a superset of the existing 1/0, it works with existing form processors.

Note: This does not address the issue that arises from passing a boolean FALSE to API3 causing that field to not get updated at all. I'm still not sure how best to tackle that - it's a problem with API3 itself, which unfortunately API3 clients must work around.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: improved-booleans