Multiple Participant Event Registration Issue

So this looks like the fix - https://github.com/civicrm/civicrm-core/commit/16fd31ae79d9ce630d8631d52f2ec1be1e51e1ef#diff-c3c751ad9f31137a69214a8c0dcedd2fc3788f00431497be6c087d9fe5ca2687R558 - but it doesn't compute with the version you are on - ie it was fixed before 5.57 - unless you have some custom php override in place

php 7.x tolerates that NULL - php8 is increasingly grumpy about it - although I didn't think php8 would hard-fail there

hi eileen,

Thanks so much for your response; I compared the patch you suggested to what our client it running and unfortunately, as you mentioned, that patch is indeed part of our version of Civi.

Regardless, I appreciate the mention, cheers to you.

@Chipleh Thanks for reporting this issue.

I don't know how technical you are, but are you able to provide a pull request with a fix for this? If not what help do you need to get started? CiviCRM is open source and maintained by a community of active volunteer with lots of love for CiviCRM. So any help is appreciated.

hi @jaapjansma We have not yet found a resolution for this, but I will update this thread if we do find a fix.

Thanks a lot!

added in-triage label

added comp:CiviEvent sig:bug triaged labels

removed in-triage label

I've come across what I think is the same issue in a client site that is running CiviCRM 5.62.1 on Drupal 7.98 and PHP 8.1.22.

The error is:

TypeError: preg_match(): Argument #2 ($subject) must be of type string, array given in preg_match() (line 766 of /var/www/html/sites/all/modules/civicrm/CRM/Core/BAO/CustomField.php).

Which refers to this section of code:

  /**
   * Get the field id from an import key.
   *
   * @param string $key
   *   The key to parse.
   *
   * @param bool $all
   *
   * @return array|int|null
   */
  public static function getKeyID($key, $all = FALSE) {
    $match = [];
    if (preg_match('/^custom_(\d+)_?(-?\d+)?$/', $key, $match)) {
      if (!$all) {
        return $match[1];
      }
      else {
        return [
          $match[1],
          $match[2] ?? NULL,
        ];
      }
    }
    return $all ? [NULL, NULL] : NULL;
  }

The value of $key that is being passed to that function is:

array(27)
qfKey:
"CRMEventControllerRegistration4lvlnb0vh4aog8kkcc0swsg8wkcoc0c00cc48484w4s0gcck84_5690"
entryURL:
"http://REDACTED/civicrm/event/register?reset=1&amp;action=preview&amp;id=40"
first_name:
"William"
last_name:
"Mortada"
email-Primary:
"REDACTED"
custom_81:
""
hidden_processor:
"1"
additional_participants:
"1"
priceSetId:
"58"
price_136:
"Array"
price_137:
""
price_138:
""
payment_processor_id:
"23"
bypass_payment:
""
MAX_FILE_SIZE:
"67108864"
is_primary:
"1"
is_pay_later:
"0"
contact_id:
"176874"
campaign_id:
""
defaultRole:
"1"
participant_role_id:
"1"
currencyID:
"GBP"
amount_level:
"Non-member ticket - 1"
amount:
"15"
tax_amount:
""
invoiceID:
"a99c025172165023f81981c95f501130"
button:
""

Call stack:

CRM_Core_BAO_CustomField::getKeyID (CLIENT/src/drupal/sites/all/modules/civicrm/CRM/Core/BAO/CustomField.php:766)
CRM_Contact_BAO_Query->buildParamsLookup (CLIENT/src/drupal/sites/all/modules/civicrm/CRM/Contact/BAO/Query.php:655)
CRM_Contact_BAO_Query->initialize (CLIENT/src/drupal/sites/all/modules/civicrm/CRM/Contact/BAO/Query.php:559)
CRM_Contact_BAO_Query->__construct (CLIENT/src/drupal/sites/all/modules/civicrm/CRM/Contact/BAO/Query.php:524)
CRM_Event_BAO_Event::displayProfile (CLIENT/src/drupal/sites/all/modules/civicrm/CRM/Event/BAO/Event.php:1687)
CRM_Event_Form_Registration_Confirm::assignProfiles (CLIENT/src/drupal/sites/all/modules/civicrm/CRM/Event/Form/Registration/Confirm.php:1178)
CRM_Event_Form_Registration_Confirm->buildQuickForm (CLIENT/src/drupal/sites/all/modules/civicrm/CRM/Event/Form/Registration/Confirm.php:273)
CRM_Core_Form->buildForm (CLIENT/src/drupal/sites/all/modules/civicrm/CRM/Core/Form.php:728)
CRM_Core_StateMachine->perform (CLIENT/src/drupal/sites/all/modules/civicrm/CRM/Core/StateMachine.php:120)
CRM_Core_QuickForm_Action_Next->perform (CLIENT/src/drupal/sites/all/modules/civicrm/CRM/Core/QuickForm/Action/Next.php:43)
HTML_QuickForm_Controller->handle (CLIENT/src/drupal/sites/all/modules/civicrm/packages/HTML/QuickForm/Controller.php:203)
HTML_QuickForm_Page->handle (CLIENT/src/drupal/sites/all/modules/civicrm/packages/HTML/QuickForm/Page.php:103)
CRM_Core_Controller->run (CLIENT/src/drupal/sites/all/modules/civicrm/CRM/Core/Controller.php:355)
CRM_Core_Invoke::runItem (CLIENT/src/drupal/sites/all/modules/civicrm/CRM/Core/Invoke.php:319)
CRM_Core_Invoke::_invoke (CLIENT/src/drupal/sites/all/modules/civicrm/CRM/Core/Invoke.php:69)
CRM_Core_Invoke::invoke (CLIENT/src/drupal/sites/all/modules/civicrm/CRM/Core/Invoke.php:36)
civicrm_invoke (CLIENT/src/drupal/sites/all/modules/civicrm/drupal/civicrm.module:471)
menu_execute_active_handler (CLIENT/src/drupal/includes/menu.inc:527)
{main} (CLIENT/src/drupal/index.php:21)

As noted by @Chipleh, if I disable the custom fields in the profiles for this event, multiple registration works fine.

It just seems to be an issue if multiple registration is enabled and the event has custom fields defined.

Not sure about payment processors, we have only got Stripe on this particular site.

@wmortada does removing this line work - it appears to do nothing since $query is not used but I believe it is in the trace....

A pull request related to this issue has been opened with the title: #4390 (closed) remove unused code that results in errors for multiple participant registration

added has-pull-request label

@eileen @wmortada

I am seeing the similar failure however, with different error:

TypeError: Illegal offset type in CRM_Contact_BAO_Query->buildParamsLookup() (line 627 of /var/www/html/sites/all/modules/civicrm/CRM/Contact/BAO/Query.php).

Error source is same line of code and removing $query fixes the issue.

It's not used anywhere so I also think it should be safe to remove it.

Here is the PR: https://github.com/civicrm/civicrm-core/pull/29357

changed milestone to %5.71.0

closed

Thanks @kurund!

@eileen I realise that I didn't reply back in September. I must have overlooked this. Apologies for that.

For reference the merged PR is: https://github.com/civicrm/civicrm-core/pull/29358

This will be included in CiviCRM 5.71.

Multiple Participant Event Registration Issue

Child items ...

Activity