Hijack=0 ignored once registered for event
CiviCRM 5.19.2 on Wordpress 5.3
See the attached screenshots showing how registered users cannot see the post content as it has been hijacked by CiviCRM
Activity
The shortcode should have a
hijacksetting:[civicrm component="event" id="7" action="register" mode="live" hijack="0"]0is don't hijack, allow other content,1is hijack prevent the display of other contentI tried that, it didn't work. Also, shouldn't "no hijack" be the default if hijack isn't specified?
Edited by CoreyBurgerI cannot reproduce the error, when I remove the
hijackoption the content still displays. I am on a clean environment when I test, but the hijack option is working on all our sites. I agree as the check isif ( isset( $atts['hijack'] ) AND $atts['hijack'] == '1' ) {If it's not set the content should not be hijacked.
I did try with the Block Editor, but for all our sites that use Shortcodes we create that content using Classic editor. But there should be no difference.
Do you have any errors in the console
Nothing in console beyond Resource URLs: Make them portable but I do have a shortcode related error in the log:
[debug] $backTrace = #0 /home/gvccbcca/public_html/wp-content/plugins/civicrm/civicrm/CRM/Core/Error.php(385): CRM_Core_Error::backtrace("backTrace", TRUE) #1 (closed) /home/gvccbcca/public_html/wp-content/plugins/civicrm/civicrm/CRM/Core/Controller.php(833): CRM_Core_Error::fatal("We can't load the requested web page. This page requires cookies to be enable...") #2 (closed) /home/gvccbcca/public_html/wp-content/plugins/civicrm/civicrm/CRM/Core/Controller.php(853): CRM_Core_Controller->invalidKeyCommon() #3 (closed) /home/gvccbcca/public_html/wp-content/plugins/civicrm/civicrm/CRM/Contribute/Controller/Contribution.php(74): CRM_Core_Controller->invalidKeyRedirect() #4 /home/gvccbcca/public_html/wp-content/plugins/civicrm/civicrm/CRM/Core/Controller.php(312): CRM_Contribute_Controller_Contribution->invalidKey() #5 /home/gvccbcca/public_html/wp-content/plugins/civicrm/civicrm/CRM/Core/Controller.php(206): CRM_Core_Controller->key("CRM_Contribute_Controller_Contribution", TRUE, FALSE) #6 (closed) /home/gvccbcca/public_html/wp-content/plugins/civicrm/civicrm/CRM/Contribute/Controller/Contribution.php(55): CRM_Core_Controller->__construct("CiviContribute", "null") #7 (closed) /home/gvccbcca/public_html/wp-content/plugins/civicrm/civicrm/CRM/Core/Invoke.php(285): CRM_Contribute_Controller_Contribution->__construct("CiviContribute", TRUE, "null", NULL, "false") #8 (closed) /home/gvccbcca/public_html/wp-content/plugins/civicrm/civicrm/CRM/Core/Invoke.php(84): CRM_Core_Invoke::runItem((Array:15)) #9 (closed) /home/gvccbcca/public_html/wp-content/plugins/civicrm/civicrm/CRM/Core/Invoke.php(52): CRM_Core_Invoke::_invoke((Array:3)) #10 (closed) /home/gvccbcca/public_html/wp-content/plugins/civicrm/civicrm.php(1441): CRM_Core_Invoke::invoke((Array:3)) #11 (closed) /home/gvccbcca/public_html/wp-content/plugins/civicrm/includes/civicrm.shortcodes.php(344): CiviCRM_For_WordPress->invoke() #12 (closed) /home/gvccbcca/public_html/wp-includes/shortcodes.php(325): CiviCRM_For_WordPress_Shortcodes->render_single((Array:2), "", "civicrm") #13 internal function: do_shortcode_tag((Array:7)) #14 (closed) /home/gvccbcca/public_html/wp-includes/shortcodes.php(199): preg_replace_callback("/[([?)(civicrm)(?![\w-])([^]/](?:/(?!])[^]/])*?)(?:(/)]|](?:([^...", "do_shortcode_tag", "[civicrm component="contribution" id="1"]") #15 (closed) /home/gvccbcca/public_html/wp-content/plugins/civicrm/includes/civicrm.shortcodes.php(230): do_shortcode("[civicrm component="contribution" id="1"]") #16 (closed) /home/gvccbcca/public_html/wp-includes/class-wp-hook.php(288): CiviCRM_For_WordPress_Shortcodes->prerender(Object(WP)) #17 (closed) /home/gvccbcca/public_html/wp-includes/class-wp-hook.php(312): WP_Hook->apply_filters(NULL, (Array:1)) #18 (closed) /home/gvccbcca/public_html/wp-includes/plugin.php(544): WP_Hook->do_action((Array:1)) #19 (closed) /home/gvccbcca/public_html/wp-includes/class-wp.php(742): do_action_ref_array("wp", (Array:1)) #20 (closed) /home/gvccbcca/public_html/wp-includes/functions.php(1250): WP->main("") #21 (closed) /home/gvccbcca/public_html/wp-blog-header.php(16): wp() #22 (closed) /home/gvccbcca/public_html/index.php(17): require("/home/gvccbcca/public_html/wp-blog-header.php") #23 (closed) {main}
Edited by CoreyBurger@CoreyBurger This error seems to be for a Contribution Page inserted via a shortcode. I don't think it's relevant here.
added comp:CiviEvent git:civicrm-wordpress sig:unverified-bug triaged labels
@haystack what do you think? I have not been able to reproduce, I've assumed the issue is the way statusBounce works when you are registered.
I think there might be an error multiple shortcodes.
@kcristiano This isn't relevant here. Code looks fine to me.
Looking at https://github.com/civicrm/civicrm-core/blob/master/CRM/Event/Form/Registration/Register.php, it is redirecting the URL. I think this might be what is happening.
Check the difference between: https://gvcc.bc.ca/come-to-the-december-esquimalt-local-committee-meeting/?page=CiviCRM&q=civicrm%2Fevent%2Finfo&reset=1&id=4&noFullMsg=false and https://gvcc.bc.ca/come-to-the-december-esquimalt-local-committee-meeting/
Looking at https://github.com/civicrm/civicrm-core/blob/master/CRM/Event/Form/Registration/Register.php, it is redirecting the URL. I think this might be what is happening.
@CoreyBurger @kcristiano Yes, this is exactly what's responsible. As soon as the
page=CiviCRMquery var is present in the URL, then the page/post is handled as if it were the basepage andhijackis therefore in operation. This doesn't occur when using the shortcode withaction="info"since no redirect occurs in that case.Given that the redirect takes place during the CiviCRM
invokeprocess and given that CiviCRM relies on thepathto build the form (the redirect takes place during thepreProcessphase of building the "Registration" form) I'm not clear how CiviCRM would serve up the "Event Info" page without the redirect. That's a direct result of CiviCRM's "one operation per HTTP request" inflexibility, I'm afraid
There are number of possible options at this stage:
- Use
action="info"and notaction="register"in the shortcode. - Combine the information from the WordPress post into the CiviCRM Event so it's always present.
- Find some complicated way to prevent the redirect given the particular circumstances.
- If all else fails, use CiviCRM Event Organiser ;-)
Choose one.
Edited by haystack- Use
That's a bit frustrating, but glad I understand how it is happening. Is this something that will be fixed with afform? I use Caldera Forms for my volunteer pages and will be rolling it out for membership, but those are largely static pages, whereas we have continual events and manually editing the form is a headache.
manually editing the form is a headache.
@CoreyBurger Which form are you referring to?
Hi,
Thank you for raising an issue to help improve CiviCRM. As you may know, this issue has not had any activity for quite some time, so we have closed it.
We would like you to help us to determine if this issue should be re-opened:
- If this issue was reporting a bug, can you attempt to reproduce it on a latest version of CiviCRM?
- If this issue was proposing a new feature, can you verify if the feature proposal is still relevant? Did it get the concept-approved label? Have other people also shown interest? Could it be implemented as an extension?
If the answer to either question is yes, please feel free to comment or re-open the issue. Please also consider:
- Is it something that you could help implement, either by sending a patch or hiring someone who can?
- Would you be willing to fund the work, either through a CiviCRM partner, or the Core Team?
Thank you for your help and contributions to CiviCRM.
P.S. This is an automated message, see
infra/gitlabissue 20. We understand that automatic responses are annoying, but given the number of open issues as the project evolves, we need a bit of help to triage and prioritise the most relevant issues.
