Fix Issue 2307

[REF] Move instantiation of Order class to earlier in function

Deprecate Pledge::add() function

This function is no longer called from anywhere and we have settled on preferring 1 create function and
standardising on that. I have left the inner code there but added the deprecation notice

This is part of making the Order object and it's methods available to the non-renewal
form which has the same amount calculation bug the class is used to fix.

Note the Order class is an internal class not the order api which we do wish to switch this
form to using

#2204 Bump Minimum install PHP 7.2

Fix pledge to not use pass-by-reference

[REF] Fix Order class to not reload if already loaded

Remove call to loadRelatedObjects

[REF] Move code closer to where it is used

[NFC] Whitespace fix up

Simply moves a few lines of code so the actual usage is apparent

[Test] Extend new membership form to cover multi-line renew + minor cleanup

[REF] Param simplification

We have deprecated this out of BAO classes

[NFC] Preliminary cleanup

[REF] Minor cleanup on emailReceipt

None of the ids loaded in this function are used anymore so we can remove the call to it
The only reference to ids after this line is to contribution page id, which is loaded earlier

On looking at this param it can only be reached if recur->id is set and the other criteria can be
squashed to an empty check

Fixes 2 things
1) empty check on line items when it is never set
2) starts to move code out of the shared-function to the form function
when it is only possible when called via the form function. The sharing here
is one of those cases where only a small part of the shared code is actually shared

REF Ensure that when doing RLIKE BINARY the field is cast as BINARY t…

5.34

Add release-notes/5.33.2

(wordpress#85) Fix version number reported within WordPress admin UI

#2297 - E_NOTICE on contribution thankyou_date_time since time component no longer a separate field

Add setting default to speed up cache flush

Detailed discussion in #2031 but note
this does not add vendor in to make it easier to get it merged (as
there is more complexity there

#2288 - Alternative fix search range for select/radio custom fields - now disabling the combination

"Admin => Misc" - Fix validation of "Maximum File Size"