fix improper use of array in StripeIPN

To fix missing data from before the mjwshared 1.2.17 fix, I tried Stripe.ipn and Stripe.retryall APIs. Both gave me an error that I can't access on object as an array.

At first I thought there were two code paths to Civi\Stripe\Webhook\Events::setData(), one that provides an array, the other an object. But lines like:

if (($this->getData()->object['object'] ?? '') !== 'invoice') {

are immediately followed by lines like:

$invoiceID = $this->api->getValueFromStripeObject('invoice_id', 'String', $this->getData()->object);

One requires $this->getData()->object to be an array, the other an object, so they both can't be right.

This standardizes all usages of $this->getData()->object to treat it as an object.

Civi/Stripe/Webhook/Events.php

@@ -287,7 +287,7 @@ class Events {
     $return = $this->getResultObject();
 
     // Check we have the right data object for this event
-    if (($this->getData()->object['object'] ?? '') !== 'charge') {
+    if (($this->getData()->object->object ?? '') !== 'charge') {
       $return->message = $this->formatResultMessage(__FUNCTION__, 'Invalid object type');
       return $return;
     }
@@ -407,7 +407,7 @@ class Events {
     $return = $this->getResultObject();
 
     // Check we have the right data object for this event
-    if (($this->getData()->object['object'] ?? '') !== 'charge') {
+    if (($this->getData()->object->object ?? '') !== 'charge') {
       $return->message = $this->formatResultMessage(__FUNCTION__, 'Invalid object type');
       return $return;
     }
@@ -504,7 +504,7 @@ class Events {
     $return = $this->getResultObject();
 
     // Check we have the right data object for this event
-    if (($this->getData()->object['object'] ?? '') !== 'charge') {
+    if (($this->getData()->object->object ?? '') !== 'charge') {
       $return->message = $this->formatResultMessage(__FUNCTION__, 'Invalid object type');
       return $return;
     }
@@ -558,7 +558,7 @@ class Events {
     $return = $this->getResultObject();
 
     // Check we have the right data object for this event
-    if (($this->getData()->object['object'] ?? '') !== 'checkout.session') {
+    if (($this->getData()->object->object ?? '') !== 'checkout.session') {
       $return->message = $this->formatResultMessage(__FUNCTION__, 'Invalid object type');
       return $return;
     }
@@ -659,7 +659,7 @@ class Events {
     $return = $this->getResultObject();
 
     // Check we have the right data object for this event
-    if (($this->getData()->object['object'] ?? '') !== 'invoice') {
+    if (($this->getData()->object->object ?? '') !== 'invoice') {
       $return->message = $this->formatResultMessage(__FUNCTION__, 'Invalid object type');
       return $return;
     }
@@ -775,7 +775,7 @@ class Events {
     $return = $this->getResultObject();
 
     // Check we have the right data object for this event
-    if (($this->getData()->object['object'] ?? '') !== 'invoice') {
+    if (($this->getData()->object->object?? '') !== 'invoice') {
       $return->message = $this->formatResultMessage(__FUNCTION__, 'Invalid object type');
       return $return;
     }
@@ -835,7 +835,7 @@ class Events {
     $return = $this->getResultObject();
 
     // Check we have the right data object for this event
-    if (($this->getData()->object['object'] ?? '') !== 'invoice') {
+    if (($this->getData()->object->object?? '') !== 'invoice') {
       $return->message = $this->formatResultMessage(__FUNCTION__, 'Invalid object type');
       return $return;
     }
@@ -895,7 +895,7 @@ class Events {
     $return = $this->getResultObject();
 
     // Check we have the right data object for this event
-    if (($this->getData()->object['object'] ?? '') !== 'subscription') {
+    if (($this->getData()->object->object ?? '') !== 'subscription') {
       $return->message = $this->formatResultMessage(__FUNCTION__, 'Invalid object type');
       return $return;
     }
@@ -938,7 +938,7 @@ class Events {
     $return = $this->getResultObject();
 
     // Check we have the right data object for this event
-    if (($this->getData()->object['object'] ?? '') !== 'subscription') {
+    if (($this->getData()->object->object ?? '') !== 'subscription') {
       $return->message = $this->formatResultMessage(__FUNCTION__, 'Invalid object type');
       return $return;
     }