Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Stripe Stripe
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 88
    • Issues 88
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 5
    • Merge requests 5
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Extensions
  • StripeStripe
  • Merge requests
  • !198

handle null balance trxn id when calculating fees

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged JonGold requested to merge JonGold/stripe:null-balance-trxn into master Sep 22, 2022
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 1

I had an invoice that is a pro-rated refund of a recurring payment. When I run the Stripe.retryall API, this crashes in CRM_Core_Payment_StripeIPN::setInfo() because we try to set a fee when the $balanceTransactionID is NULL. Since CRM_Core_Payment_Stripe::getFeeFromBalanceTransaction() is clearly set up to handle this scenario (based on the docblock and the if statement) I've changed the function signature to allow a NULL value.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: null-balance-trxn