CiviCRM 5.70 compatibility (rounding issue) ?

We have this problem when doing a payment on a contribution page since the upgrade to CiviCRM 5.70 :

In our context the total amount is 57.4875 (50$ + quebec taxes).

Apparently, Stripe is using Brick which expect some strategy for the rounding.

mentioned in merge request !248 (merged)

PR is solving it for me but I'm not 100% sure about the choosen RoundingMode. I tried a few and RoundingMode::HALF_EVEN seems ok.

Hi @samuelsov what I don't understand is why this would only be an issue with 5.70. Did something change there (eg. brick library version)?

@samuelsov Looks like CiviCRM core is using HALF_UP - can you change it to that?

changed title from CiviCRM 5.70 compatibility ? to CiviCRM 5.70 compatibility (rounding issue) ?

Related: #426 we should resolve both issues at the same time if possible.

mentioned in issue #465 (closed)

I think this issue is resolved. I experienced the same issue in 5.69 and the patch fixed it. I don't think it's related to 5.70 or any changes in core. Instead, sometimes when doing math you end up with a number like 5.02 which doesn't need to be rounded and sometimes you end up with 5.023 which does. I suspect that variance is what makes it seem like this problem just started happening.

mentioned in issue dev/core#5162 (closed)