Stripe elements should be in the same language as the site
Currently, the Credit Card fields displayed by Stripe are always in English.
Stripe supports the following languages: ar, da, de, en, es, fi, fr, he, it, ja, lt, lv, ms, nl, no, pl, pt, ru, sv, zh (https://stripe.com/docs/stripe-js/reference).
There is a locale param available for the Stripe object that we can use:
stripe = Stripe(CRM.vars.stripe.publishableKey, {locale: 'fr'});Example:
I'll try to see if we can add a locale variable to CRM.vars.stripe, if the locale is supported by Stripe.
Activity
added bug label
@bgm That would be good! By the way, I've noticed that it has started picking up my browser locale (PT) sometimes without me making any changes. Also worth checking out the recent change that enabled multilanguage on mosaico.
@mattwire Good point. The doc says:
Default is 'auto' (Stripe detects the locale of the browser).
My browser was not correctly configured. However, on one client this is particularly sensitive, with people who may have very different languages as their primary language. I would be tempted to force the language, and if it's a non-supported language, leave it to "auto".
-
@bgm If you are able to get a MR for this in the next week or so I would like to get it into the 6.3 release.
added Needs funding label
added enhancement label and removed bug label
mentioned in merge request !87 (closed)
-
See !87 (closed)
changed milestone to %6.4
added Waiting feedback label and removed Needs funding label
changed milestone to %6.3
I have some problems getting the Stripe dialogs shown in German language. Basically I checked the whole software-chain: The browser, WordPress (latest version) and CiviCRM (latest version) are all set to German. But the Stripe Elements input box and messages are all in English.
What I suspect is that the value for the locale ends up as "de_DE" instead of the plain "de" which Stripe is expecting, so they are not recognizing the language and fall back to English. "de_DE" was the value set in CRM.vars.stripe.locale when I checked it in the browser console.
Tentatively, I replaced the two calls to
CRM_Core_I18n::getLocale()by just setting 'de' as the value and I had some partial success. At least the input box for the credit card number contains German text, the subsequent 3D secure test dialog is still in English. However, I am not sure if this UI-placeholder is always in English and the real UI will show the customer language.I am wondering if I am the only one having trouble with the language of Stripe Elements? Maybe I am just missing a setting somewhere?
Edited by Joachimmentioned in commit b2114a2b
mentioned in commit 5c60b46d
mentioned in commit 67fc1cd5
mentioned in commit 70ac7cc1
-
@mattwire I can confirm that the patch is working as expected. The Stripe entry field and the related error messages (e.g. incomplete card number) are now displayed in German. I am still struggling a bit with the messages in the sweetalert boxes, my Transifex translations have not been picked up and word replacement don't work neither. But this is a totally separate issue and could be my setup and lack of experience in this area, so I will dig into this a bit more before asking questions.
-
@priojk Thanks that's good! I don't see any translations on transifex? Can you open a new issue here for the transifex translations? I'd like to make sure that they work well too and it would be great to see a working example
-
Sorry for not getting back earlier - had some other urgent issues to solve. Regarding the translations: So far I have set up a transifex account and worked on a file locally. Will try to upload a first set of German translations hopefully during the next week and then open an issue, if still necessary.
mentioned in commit dfc97ca9
mentioned in commit 1ec198c5
mentioned in commit 7b9e04d4
mentioned in commit 1cd99073
mentioned in commit 1cfb7bbf
mentioned in commit 3be58df8
mentioned in commit 78d0b9b7
mentioned in commit fd7bbb87
mentioned in commit 39d2d7c0
mentioned in commit 247b0977
mentioned in commit 26b943dc