Jamie McClelland authored 6 years ago and mattwire committed 6 years ago

When you select a priceset with the value 0, the form properly hides
the credit card input fields.

However, we still try to submit a credit card to stripe which results in
an error.

If we wait for the event handler to kick in, other js code
might run first (like offline event registration does an ajax
call to register a participant).

Without this patch, you can the error "no such token" if:

 * You have two different stripe payment processors configured.
 * you are making an offline contribution
 * using the provided payment processor back end, you choose the
 non-default payment processor.

The stripe javascript submits the payment using the default payment
processor, but the PHP codes tries to charge it using the user-selected
payment processor, which leads to the error.

This fix also ensures that if a non-stripe payment processor is chosen
we won't try to send it to stripe.

Without this patch, an attempt to submit a webform with a payment option
that totals $0 gets the error: Error: Could not find payment
information.

That's because the check for a total price of $0 fails. It fails for two
reasons:

1. Newer versions of jquery conform to html5 specs that say the data in
the field called "data-amount" should be referred to as simply "amount"
rather than "data-amount"

2. In addition, jquery now tries to convert values to their appropriate
type, so the strict matching of === '0' only matches on the string value
of '0' but jquery is converting the string '0' into the integer 0.

When stripe throws an error, and the original form as an onclick event,
we briefly see the error before the form is submitted according to
the onclick event (i.e. the PreventDefault() and return false
does not have any effect).

This fix removes any onclick attributes at the beginning and only
re-adds them and resubmits the form if we should.

Drupal Webform: Re-enable hook_civicrm_buildForm and comment in different situations we need alterContent and buildForm to load js scripts

mattwire authored 7 years ago and mattwire committed 7 years ago

Always load civicrm_stripe.js if we have a payment processor on the page. This makes sure we always generate a token if the selected processor was stripe

mattwire authored 7 years ago and mattwire committed 7 years ago

Always load stripe.js when on a payment processor page (recommended by stripe for fraud detection).

Fix in civicrm_stripe.js that was causing "Stripe.js Not passed" because token was empty.
Fix error message about accessing static variable.
Large cleanup to code structure in stripe.php.

Modify to stop error "Error: Stripe.js token was not passed! Report this message to the site administrator" on pressing confirm payment for event.

Due to changes in CiviCRM you can no longer count on hidden_processor
field being present.

See https://issues.civicrm.org/jira/browse/CRM-15743