When stripe throws an error, and the original form as an onclick event,
we briefly see the error before the form is submitted according to
the onclick event (i.e. the PreventDefault() and return false
does not have any effect).

This fix removes any onclick attributes at the beginning and only
re-adds them and resubmits the form if we should.

Drupal Webform: Re-enable hook_civicrm_buildForm and comment in different situations we need alterContent and buildForm to load js scripts

mattwire authored 7 years ago and mattwire committed 7 years ago

Always load civicrm_stripe.js if we have a payment processor on the page. This makes sure we always generate a token if the selected processor was stripe

mattwire authored 7 years ago and mattwire committed 7 years ago

Always load stripe.js when on a payment processor page (recommended by stripe for fraud detection).

Fix in civicrm_stripe.js that was causing "Stripe.js Not passed" because token was empty.
Fix error message about accessing static variable.
Large cleanup to code structure in stripe.php.

Modify to stop error "Error: Stripe.js token was not passed! Report this message to the site administrator" on pressing confirm payment for event.

Due to changes in CiviCRM you can no longer count on hidden_processor
field being present.

See https://issues.civicrm.org/jira/browse/CRM-15743

** This would cause the "Stripe.js token not passed!" because of a JS error.

Fix form not submitting issue, use cached selectors where possible, clear onbeforeunload, remove onclick which cased premature submit

updated stripe to v2, make compatiable with webform_civicrm, code cleanup / generalization to work with civicrm + webform, prevent sensitive data transfer across the server to ensure PCI compliance, also notice and indentation fixes

Direct child selector was failing because of the way forms are written in 4.5. Removing the direct child selector fixed the issue. Also added condition to check for jQuery dialog forms as well.