Use CRM.payment.isAJAXPaymentForm() and update mjwshared requirement to 0.9.6

CRM/Stripe/Check.php

@@ -25,7 +25,7 @@ class CRM_Stripe_Check {
   /**
    * @var string
    */
-  const MIN_VERSION_MJWSHARED = '0.9.4';
+  const MIN_VERSION_MJWSHARED = '0.9.6';
   const MIN_VERSION_SWEETALERT = '1.4';
   const MIN_VERSION_FIREWALL = '1.1';
 

docs/releasenotes.md

@@ -9,6 +9,11 @@ Releases use the following numbering system:
 
 * **[BC]**: Items marked with [BC] indicate a breaking change that will require updates to your code if you are using that code in your extension.
 
+## Release 6.5.4 (not yet released 2020-10-24)
+**This release REQUIRES that you upgrade mjwshared to 0.9.6**.
+
+* Use `CRM.payment.isAJAXPaymentForm()` to check if we should load on backend forms. There is no change for the user, we are just switching to an identical shared function to reduce code duplication.
+
 ## Release 6.5.3
 
 * Fix [#258](https://lab.civicrm.org/extensions/stripe/-/issues/258) Credit card element doesn't load in "Submit credit card contribution" popup form on backend (fixed for memberships and contributions).

info.xml

@@ -15,9 +15,9 @@
     <author>Matthew Wire (MJW Consulting)</author>
     <email>mjw@mjwconsult.co.uk</email>
   </maintainer>
-  <releaseDate>2020-10-21</releaseDate>
-  <version>6.5.3</version>
-  <develStage>stable</develStage>
+  <releaseDate>2020-10-24</releaseDate>
+  <version>6.5.4-dev</version>
+  <develStage>beta</develStage>
   <compatibility>
     <ver>5.28</ver>
   </compatibility>

js/civicrm_stripe.js

@@ -26,10 +26,7 @@
     // /civicrm/payment/form? occurs when a payproc is selected on page
     // /civicrm/contact/view/participant occurs when payproc is first loaded on event credit card payment
     // On wordpress these are urlencoded
-    if ((settings.url.match("civicrm(\/|%2F)payment(\/|%2F)form") !== null) ||
-      (settings.url.match("civicrm(\/|\%2F)contact(\/|\%2F)view(\/|\%2F)participant") !== null) ||
-      (settings.url.match("civicrm(\/|\%2F)contact(\/|\%2F)view(\/|\%2F)membership") !== null) ||
-      (settings.url.match("civicrm(\/|\%2F)contact(\/|\%2F)view(\/|\%2F)contribution") !== null)) {
+    if (CRM.payment.isAJAXPaymentForm(settings.url)) {
       debugging('triggered via ajax');
       load();
     }