Expand compare date

This merge request has two pieces:

1. Expand the Activity Date Comparison to be able to compare to date fields on the Contact. A few fields were changed to make the UI a bit more intuitive. It should be backwards compatible, but I did not have very many of the rules to test with.
2. Add support for Participants and Events in this Condition. I considered adding a separate rule for these, but the code would have been almost identical.

I am going to be using this condition in a live setting, but additional testing would be helpful.

added 22 commits

• c2b50890...93195a78 - 21 commits from branch extensions:master
• fd4a175c - Merge branch 'master' into compare-date-value

Compare with previous version

added 12 commits

• fd4a175c...6aaf88bb - 11 commits from branch extensions:master
• 136e3245 - Merge remote-tracking branch 'upstream/master' into compare-date-value

Compare with previous version

unmarked as a Work In Progress

I have been using this condition in a live environment for a few week. It is working properly.

I just merged upstream master back into this branch. Does the updater need any modification?

I am not so sure whether this the right solution. You have made the ActivityDate a generic concept. I agree with the generic concept however, I dont agree that this class then should be called ActivityDate. And that brings me to the worry that it might break existing configurations of CiviRules.

Thank you for the feedback! What would you suggest would be a good path forward for this concept?

Probably put the whole thing in CRM/CiviRulesConditions/Generic and leave the current condition unchanged.

Makes sense. I will do that.

mentioned in merge request !100 (merged)

closed