Skip to content

Issue #86 "Last Contribution of a Contact"

Sandor Semsey requested to merge (removed):issue-86 into master

Fix for issue #86 (closed)

Present

When checking for comparison value CRM_CivirulesConditions_Contribution_LastContribution uses the parents (CRM_CivirulesConditions_Generic_ValueComparison) getComparisonValue method because it is not overridden it this class.

But that method needs an entity condition parameters which is not available for this condition, so it returns an empty string. This empty string is used for comparison and it yields unexpected results in CRM_CivirulesConditions_Generic_ValueComparison::isConditionValid.

Proposal

Override getComparisonValue to return the value saved in condition parameters.

Merge request reports

Loading