Option to modify linked Trigger

this is more a wish list than an issue. It would be great to be able to have an option to modify a rule when creating it. For not yet experienced users, sometime finding the right trigger takes time. And when setting a CiviRule it would be helpful to modify the linked trigger instead of deleting/creating because one didn't choose the proper trigger.

Ah yes! This would be great to add. You can do it by editing the database directly but it would be better via the UI.

The only issue is the checking if the conditions are still allowed for the new trigger.

The only issue is a bit of an understatement here I think @mattwire. Functionally that has potentially massive impact which destroys any benefit......

Haha :-) I agree it would be a lot of work and could make things too complex. But it sure would be nice to be able to change from eg Contribution Added to Contribution edited when you realise you selected the wrong one.

@mattwire I can see that working, changing from added to edited within the same entity. But not changing the entity.....

I don't even reach the conditions stage because I'm trying to figure out which trigger to use and if I figure out that this is not the expected trigger I won't go on any further. Imagine mistaking between Contribution is Added and Membership Contribution is Added, you just want to step backwards.

I do not think this is a good idea. It would make Civirules more complicated for the user, cause all sorts of errors they would not comprehend. We as developers would be able to make sense of it but I do not see the big benefit? It it is not that hard to create a new rule....What do you think @jaapjansma ?

When having a Rule with 10 actions and diverse paramters for each, have fun rewriting the entire actions stack again with a new trigger when not able to modify the database... So definetely +1 here!

Once again, I understand the functional complications but being able to change the trigger does not make it simpler, on the contrary! Linked conditions and actions might not be possible with the new trigger, and there is no way the developer can predict what should happen. Imagine you would be able to change the trigger from new activity to new contact, most of the conditions would not be valid anymore. This is from my perspective not feasible. And if we do check if the conditions and actions are applicable and remove the ones that are not it would not improve the workload.....so no, I still do not see the benefit, only more problems.

Maybe I wasn't clear enough, I was just thinking of one step backwards like @mattwire says when you mistook yourself while selecting the action. I understand that modifying everything is of no interest.

I agree with @ErikHommel. When a user is able to change the trigger configured conditions and actions might suddenly break or have unexpected behaviour and that would happen in most cases. I believe it is safer to start over again then to check all your conditions and actions. I can understand that when you make a mistake it takes some work to undo. But CiviRules is powerful and with great power comes great responsibility.

Makes this sense and shall we close this issue?

I think you can, this was just for confort I guess :-)

closed