Rework on the missing button, removes minor notices. Implements #8
Reworks the issue after the logic change in CiviCRM 5.31. Implement #8 (closed)
Merge request reports
Activity
@bgm can you review?
Hi @VangelisP, thanks for the patch!
What is an
xbutton
element? Is it official, or was it to disable it?I don't mind removing that button completely. It's a leftover from the 4.6 days, and would simplify the code if we removed it.
Hey @bgm , this refers to this "new" approach to render a button after the 5.31 changes.
People actually do tend to use it
mentioned in commit bf226ecf
@VangelisP Perfect - thank you!
I will try to do an official release later today.
@VangelisP I did a small tweak for Shoreditch support - hopefully it does not cause regressions for you:
1b22616eEdited by bgm@bgm it works just fine with your tweak (on a vanilla CiviCRM without Shoreditch). We are good for a new release ;)
mentioned in issue #11 (closed)