Remove Base Page content filter once it has been used

Since the Base Page should only be rendered once, we can dispense with the content filter once it has run. This would solve this issue raised on StackExchange without needing extra code.

PR to follow.

PR here: https://github.com/civicrm/civicrm-wordpress/pull/240

added git:civicrm-wordpress label

Thanks @haystack. Can you think of someone who could have an opinion on this? @yashodha maybe?

added triaged label

@BjoernE The issues I open here are more for completeness (in the post-Jira era) before I submit a PR on GitHub. In many ways it's confusing to have discussion both here and on GitHub - I'd prefer it if it were only on one platform TBH but

Can you think of someone who could have an opinion on this?

@BjoernE Good question! I welcome feedback from anyone and everyone of course! At the moment I can't think of anyone who is primarily WordPress-focussed like myself and @kcristiano. Would love to find out.

@haystack The PR looks intriguing. I'll spin up a zip and add to some of my RC/dev sites so I can see with real life pages.

What do we expect the URL of the confirmation page to be? page slug (with shortcode)? basepage? cleaner URLs?

@kcristiano The removal of the filter does nothing but prevent subsequent calls to the_content() from showing the CiviCRM content. You can see the effect by installing something like A Featured Page Widget and changing the output of the widget from the_excerpt() to the_content(). If you do so, you'll see duplicated CiviCRM content in the output of the widget. With the PR, you won't, you'll see the content of the featured Page.

Closing since the PR has been merged.

closed

mentioned in issue #107 (closed)