Billing Address params on propertyBag
We currently have a set of billingXxx
fields on propertyBag but they have no mappings to what actually gets passed in.
Because of CRM_Core_Form::prepareParamsForPaymentProcessor
we can be pretty certain that fields will be available in the format without the billing_
prefix.
But the mapping is still not completely clear:
'billingStreetAddress' => TRUE,
'street_address' => 'billingStreetAddress',
'billingSupplementalAddress1' => TRUE,
'billingSupplementalAddress2' => TRUE,
'billingSupplementalAddress3' => TRUE,
'billingCity' => TRUE,
'city' => 'billingCity',
'billingPostalCode' => TRUE,
'postal_code' => 'billingPostalCode',
'billingCounty' => TRUE,
'state_province' => 'billingCounty',
'billingCountry' => TRUE,
'country' => 'billingCountry',
In particular:
- "County" has various meanings and we should probably standardise on
stateProvince
withCounty
being the next level down. - Should the params be prefixed with
billingXxx
at all in propertyBag? OraddressXxx
or justxxx
. - Do we need the supplementalAddress params at all - I don't think anything (payments) uses them?
Ping @eileen @artfulrobot @KarinG