Adding "standard" params to propertyBag
View options
- Truncate descriptions
This came out of https://github.com/civicrm/civicrm-core/pull/18425 and https://github.com/civicrm/civicrm-core/pull/17595.
Specifically, adding "standard" parameters to propertyBag when they are already in use by a payment processor that has been converted to use propertyBag is likely to break existing implementations.
Accessing params that are later added as "standard" params to propertyBag when a payment processor is already converted internally to propertyBag (eg. most of the ones written by me Stripe, authnetecheck, Smartdebit).
Example Issues:
- authnetecheck accesses
$params['credit_card_number']
which disappears once mapped to a propertyBag because only the standardisedcardNumber
field is available. - If authnetecheck was using
$propertyBag->getCustomProperty('credit_card_number')
it would throw an "InvalidArgumentException" because you are not allowed to usegetCustomProperty
for a "standard" property.
Similar issues will apply to any other properties that are already in use by a payment processor.
- Show labels
- Show closed items