Adding "standard" params to propertyBag
Specifically, adding "standard" parameters to propertyBag when they are already in use by a payment processor that has been converted to use propertyBag is likely to break existing implementations.
Accessing params that are later added as "standard" params to propertyBag when a payment processor is already converted internally to propertyBag (eg. most of the ones written by me Stripe, authnetecheck, Smartdebit).
- authnetecheck accesses
$params['credit_card_number']which disappears once mapped to a propertyBag because only the standardised
cardNumberfield is available.
- If authnetecheck was using
$propertyBag->getCustomProperty('credit_card_number')it would throw an "InvalidArgumentException" because you are not allowed to use
getCustomPropertyfor a "standard" property.
Similar issues will apply to any other properties that are already in use by a payment processor.