Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
F
Financial
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 82
    • Issues 82
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Development
  • Financial
  • Issues
  • #135

Closed
Open
Opened Jun 13, 2020 by eileen@eileen🎱Owner

Fix all core processors to implement doPayment and not doTransferPayment or doDirectPayment

Sub issue of #130 via #132

Summary from @KarinG

doDirectPayment and doTransferCheckout will soon be flagged deprecated PR in Core: https://github.com/civicrm/civicrm-core/pull/17456

Here's a documentation block: https://github.com/civicrm/civicrm-core/blob/master/CRM/Core/Payment.php#L1324-L1332

If your Payment Processor code is using doDirectPayment -> here's how to move to doPayment!

1a -> note that doPayment should throw an exception rather than return an error: Specific Example by @eileen -> replacing a CRM_Core_Error with a throw new PaymentProcessorException https://github.com/civicrm/civicrm-core/pull/17565/files#diff-abf3be8fd9a6ed43b68f6d8439c85f2fL140

1b -> then rename doDirectPayment -> doPayment Example PR by @KarinG https://github.com/iATSPayments/com.iatspayments.civicrm/pull/310

1c -> testing! Don't forgot to also test an unsuccessful transaction -> then you know what your notices will look like.

1d -> if you have any doTransferCheckout -> replace that with doPayment as well.

Edited Aug 21, 2020 by eileen
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: dev/financial#135