Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • F Financial
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 90
    • Issues 90
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Development
  • Financial
  • Issues
  • #132

Closed
Open
Created Jun 07, 2020 by eileen@eileen🎱Owner

Model best practices in our core processors

Subissue of #130

Subtasks for this issue Throw exceptions, do not return error object #131 (closed)

Implement doPayment, do not implement doTransferPayment, doDirectPayment #135 (closed)

  • this is currently blocked on clarifying return parameters #141 (closed)

Cast $params to a PropertyBag at the start of the function

  • note this is currently blocked on PropertyBag support for the full range of properties - see #130 (comment 42912)

Use Guzzle, not Curl #143

Have tests So far the following processors have tests

  • Paypal (all versions)
  • Authorize.net
  • Eway
  • Payflow Pro
  • Dummy
Edited May 17, 2021 by eileen
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking