contribution detail report errors when soft credits column is exposed

to reproduce:

1. create a new contrib details report (or open existing)
2. select Soft Credits column
3. run the report

this errors with a "no such field" message.

@eileen this appears to be caused by your commit here: https://github.com/civicrm/civicrm-core/commit/81a22d3d60938a857185986c66d60505f4b60c00#diff-585f40aa84b2e15ef6b0768dd64bfd0c

I haven't traced exactly where yet. But when I roll back to the prior version of the file it works properly.

Sigh - another FGB regression :-(

added regression sig:bug triaged labels

Hi @lcdweb I'm doing a patch for this for you to review. I think this report has been pretty problematic so despite this being a regression I don't want to rush a patch release out without really getting the report under tests - will put something up for you to review

mentioned in commit d8c6d175

mentioned in commit f2ecd9fd

mentioned in commit a72736cf

mentioned in commit 1d48b4c0

mentioned in commit 375e96d1

mentioned in commit 89e61d6f

Regression analysis 5.2.0 What happened? A patch to make Contribution Detail report compliant with FULL_GROUP_BY mysql mode causes the display of one field (soft_credits) to break. #170 (closed)

How & When was it addressed Patch release 5.2.1 released within 48 hours.

How did the regression fit with our processes? The issue was handled in conjunction with our processes at the time and it’s not obvious that someone should have thought to test that field. However, shortly after that fix was made we stopped changing working queries to comply with full group by mode (due to a history of regressions) and started to by-pass full group by where it was known not to work. This & last month’s issue should be the tail end of the FULL_GROUP_BY issues.

This report has known testability problems and we started to address that last month & with the fix for this regression we have a path to ensure any further fixes on this (known to be problematic) report get tests.

Context Unit testing on reports is relatively new and coverage is relatively poor and for some reports issues with how they are constructed has been a blocker. This report is notable on that front and it would have to be described as fairly toxic. In this context I am aiming for a fix that is well tested and solves the unit testing issue going into master. https://github.com/civicrm/civicrm-core/pull/12281

Recommendations going forwards Realistically the steps we have already taken - ie. getting this known-to-be-an-issue report under tests and be less aggressive on full group by fixes.

closed

mentioned in commit e6bab5ea

mentioned in issue eileen/Product-maintenance#11

mentioned in issue report#10 (moved)

mentioned in issue #3236 (closed)