No pagination on Contribution Detail report
This seems to be a side effect of this commit fixing core#170 (closed). I'm not 100% sure why this isn't happening on the sandbox, but I'm reasonably certain it's because servers without Full Group By use a different code path.
There were 2.5 bugs that needed to be fixed:
- The first temp table for this report sets a limit of 50 rows - so the second time through
buildQuery(), the SQL statement
SELECT * FROM civireport_contribution_detail_temp3 $this->_orderBywill never return more than 50, so the pager won't be set.
setPager()assumes that a) the last SQL statement executed includes
SQL_CALC_FOUND_ROWS; b) that
Finally, I found a call to
setPager() in a place where it would never be correct (on a temp table that's not the "final" temp table) so I removed it.