This is preliminary cleanup towards exposing cancel_reason as a search field, as committed to in proposal to
add the field. This change

- adds unit tests for the trxn_id & processor_id fields
- makes the handling of them more generic
- adds contribution recur field data to the contribution query object so it can be accessed.

Some points about the last of these. Basically we have a situation where the query object needs metadata to
avoid field by field handling. We have done this is some wierd & wonderful ways with dependencies on 'import' &
'export' metadata info to the point where they were given to so many fields as to become meaningless.

I think this method is better - ie. just adding the additional metadata to the query class for all the entities it
deals with. A recently merged PR means 'where' data is still available using this method.

Also I have added uniquenames to the contribution recur fields. Uniquenames no longer really matter outside
- the query object
- profiles
- possibly import & export

We only really expose recurring contribution info through the query object of these so it should be safe. In a future happy
space apiv4 & namespacing will render uniquenames a distant memory.

I couldn't rip out the special handling entirely without dealing with the labels that go into the qill. I figure
we should merge this & then address that - but briefly the issue is that Matt has just changed all the labels
to not quite work in this context so we need to discuss / agree how to manage 'Recurring Contribution Trxn ID' vs
'Trxn ID'.

I also didn't want to rip out the special handling fully in advance of https://github.com/civicrm/civicrm-core/pull/14118
being merged as there could be a performance regression if we let more code hit that unnecessary join line

REF Don't pass activity object to addCaseActivityLinks

Add function filterLinks to return an array of links for an entity that can be used by the API / form layer to generate a link

REF Use shared function to check inbound email permissions

Revert "#553: Creating new event takes value from default value not from saved template for custom fields"

[REF] Follow up tidy up on import fixes

This is covered by testImportPrimaryAddressUpdate

#880: Fix typo in DROP table query.

Fix import primary phone, primary email, add tests

Revert "#553: Creating new event takes value from default value not from saved template for custom fields"

#846 Convert Recurring forms to entity forms

#553: Creating new event takes value from default value not from saved template for custom fields

' phone & email and enable test

Prior to this selecting 'Primary' as location_type_id for phone or email will result in duplicates.

This also simplifies the indexing to be by location type, as it is with addresses, as the code is kinda
confusing

REF Replace hardcoded IDs with pseudoconstants in activity form

5.13

#891 condition on id existenced when retrieving mailing hash

(REF) Standardize UFField create function

 [REF] calll formatLocationBlock from parent function.

NFC Whitespace formatting for formButtons.tpl

Fix ts() usage in CRM_SMS_Form_Schedule

Add function filterLinks to return an array of links for an entity that can be used by the API / form layer to generate a link

This is no longer called when location_type_id is empty

This is about starting to unnest the spaghetti of functions here.....
Just deprecating for now in case

Convert Pledge Calander Date and Start Date for pledges to use datepic…

5.13

Add release-notes/5.12.3.md

Fix bug preventing affecting `cv --user` on Joomla

Add serialize metadata to tag used_for field