Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • N nihrbackbone
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Partners
  • CiviCooPCiviCooP
  • NIHR BioResourceNIHR BioResource
  • nihrbackbone
  • Merge requests
  • !13

Improved performance in logger

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open jaapjansma requested to merge jaapjansma/nihrbackbone:performance_improvement_logger into master Sep 30, 2020
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

The line of thought behind this merge request is that we are importing a large record set and each record writes several lines to the log file. And writing to a log file is writing to disk and is usually slow.

So my first step here is to minimize the calls to fputs.

Instead of calling fputs 6 times for a log line, it calls it now one time. I am not sure whether this imroves a lot but it might as we are importing a lot of records and if we log during the import it means we are also writing a lot to disk.

I have not tested this MR nor have I done any measurements whether this improves the actual performance.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: performance_improvement_logger