Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • W webtracking
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 3
    • Issues 3
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Extensions
  • webtracking
  • Merge requests
  • !1

Fix tabsets on Manage Contribution Pages page

  • Review changes

  • Download
  • Patches
  • Plain diff
Open JonGold requested to merge JonGold/webtracking:fix-tabsets into master Jan 03, 2022
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

On the "Manage Contribution Pages" page, the action links are manipulated with bitwise operations against constants like CRM_Core_Action::VIEW. It relies on the tabset array's keys being a power of 2.

The array_merge I wrapped in a conditional rewrites the array keys to be sequential from 0. This causes the link not to appear, but also removes other links ("Disable" and "Delete").

Because the bitwise operations make it all but impossible to inject a link there, and because it's already not showing up, this PR removes the code so at least "Disable" and "Delete" will show up.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-tabsets