Tests failing with 3.5
Run on Civi 5.48.2: (with output from phpunit7 --testdox
)
Summary of non-successful tests:
CRM_Civigiftaid_Declaration
✘ Set declaration logic with data set #0
│
│ Test set: existing no, adding a yes (also tests omitted given_date and provided given_date)
│ Failed asserting that actual size 1 matches expected size 2.
│
│ /buildkit/build/current/web/sites/default/files/civicrm/ext/ukgiftaid/tests/phpunit/CRM/Civigiftaid/DeclarationTest.php:163
│ /buildkit/extern/phpunit7/phpunit7.phar:615
│
✘ Set declaration logic with data set #1
│
│ Test set: existing no, adding a yes past 4
│ Failed asserting that actual size 1 matches expected size 2.
│
│ /buildkit/build/current/web/sites/default/files/civicrm/ext/ukgiftaid/tests/phpunit/CRM/Civigiftaid/DeclarationTest.php:163
│ /buildkit/extern/phpunit7/phpunit7.phar:615
│
✘ Set declaration logic with data set #3
│
│ Test set: existing yes, adding a no
│ Failed asserting that actual size 1 matches expected size 2.
│
│ /buildkit/build/current/web/sites/default/files/civicrm/ext/ukgiftaid/tests/phpunit/CRM/Civigiftaid/DeclarationTest.php:163
│ /buildkit/extern/phpunit7/phpunit7.phar:615
│
✘ Set declaration logic with data set #4
│
│ Test set: existing yes past 4, adding a no
│ Failed asserting that actual size 1 matches expected size 2.
│
│ /buildkit/build/current/web/sites/default/files/civicrm/ext/ukgiftaid/tests/phpunit/CRM/Civigiftaid/DeclarationTest.php:163
│ /buildkit/extern/phpunit7/phpunit7.phar:615
│
✘ Set declaration logic with data set #5
│
│ Test set: existing yes, adding a yes: Expect declr 1 to have reason_ended =
│ Failed asserting that two strings are equal.
│ --- Expected
│ +++ Actual
│ @@ @@
│ -''
│ +'(MISSING)'
│
│ /buildkit/build/current/web/sites/default/files/civicrm/ext/ukgiftaid/tests/phpunit/CRM/Civigiftaid/DeclarationTest.php:189
│ /buildkit/extern/phpunit7/phpunit7.phar:615
│
✘ Set declaration logic with data set #6
│
│ Test set: existing yes, adding a yes past 4, but existing declaration is older than 4 years ago: Expect declr 1 to have reason_ended =
│ Failed asserting that two strings are equal.
│ --- Expected
│ +++ Actual
│ @@ @@
│ -''
│ +'(MISSING)'
│
│ /buildkit/build/current/web/sites/default/files/civicrm/ext/ukgiftaid/tests/phpunit/CRM/Civigiftaid/DeclarationTest.php:189
│ /buildkit/extern/phpunit7/phpunit7.phar:615
│
✘ Set declaration logic with data set #7
│
│ Test set: existing yes, adding a yes past 4, but existing declaration is not older than 4 years ago Expect declr 1 to have start_date >= 2022-05-11 11:13:23
│ Failed asserting that '2020-05-01 00:00:00' is equal to '2022-05-11 11:13:23' or is greater than '2022-05-11 11:13:23'.
│
│ /buildkit/build/current/web/sites/default/files/civicrm/ext/ukgiftaid/tests/phpunit/CRM/Civigiftaid/DeclarationTest.php:184
│ /buildkit/extern/phpunit7/phpunit7.phar:615
│
FAILURES!
Tests: 30, Assertions: 191, Failures: 7.
EDIT: This seems to be around the getPartialDeclaration logic in setDeclaration().