Skip to content

Remove buildOptions function in favor of a pseudoconstant callback

colemanw requested to merge buildOptions into master

As part of my refactoring rampage in https://github.com/civicrm/civicrm-core/pull/30986 I'm trying to remove all buildOptions functions. This one seems pretty unnecessary, it's just as easy to declare it as a standard callback.

But I was unable to regenerate the DAO file from the xml because... yikes. So I just patched the DAO file by hand.

Also, I can't install this extension to test it (Cannot execute CREATE TABLE "kpunch", DB Error: unknown error) So I haven't been able to r-run this. It ought to work, I just can't verify it myself.

Merge request reports