Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Stripe
Stripe
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 39
    • Issues 39
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Extensions
  • StripeStripe
  • Merge Requests
  • !59

Closed
Opened Sep 12, 2019 by Rich@artfulrobotDeveloper
  • Report abuse
Report abuse

Fix payment method requirement for confirming payment intent

  • Overview 2
  • Commits 29
  • Changes 98

The confirm ajax endpoint attempts to confirm a payment when supplied with a payment method ID.

The result of trying that is that a Payment Intent is created.

If confirm failed (SCA) then the Intent is send back. On the second submission only the Intent is needed, but the code was requiring the payment method, too. The payment method has already been set for the intent and can't change as far as I can see.

This MR removes the requirement for passing a payment method ID, and removes the payment method ID from the call to confirm. It now calls confirm without arguments, as shown in the docs: https://stripe.com/docs/payments/payment-intents/web-manual

While it probably does no harm to pass the payment method around again, unless it's needed we should keep the code and input requirements to the minimum.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: extensions/stripe!59
Source branch: fix-payment-method