Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Stripe Stripe
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 75
    • Issues 75
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Extensions
  • StripeStripe
  • Merge requests
  • !4

5.x noemail cc

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed jamie requested to merge jamie/stripe:5.x_noemail_cc into master Oct 12, 2018
  • Overview 1
  • Commits 19
  • Pipelines 0
  • Changes 13

Here's my change to ensure that the credit card fix I made is working on your noemail branch.

In short: we should always try to update the credit card, even with a secondary transation because we can't tell if there was an initial transaction already.

Your new code fixes the error handling, but it still will let a membership payment that is not accompanied by a contribution payment slip by without having the credit card updated.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 5.x_noemail_cc