Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Stripe Stripe
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 88
    • Issues 88
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 5
    • Merge requests 5
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Extensions
  • StripeStripe
  • Merge requests
  • !197

ensure webhook data is populated.

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged jamie requested to merge jamie/stripe:populate-webhook-data into master Sep 20, 2022
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

This seems to fix #388 (closed) in the least intrusive way.

But I'm not sure it's right:

  1. I'm not sure why I have to strip off "Stripe\StripeObject JSON: " from the string stored in the database. Should that be saved differently?
  2. I'm not sure we should trust data stored in the webhook table. Maybe it would be better to do away with that call and simply set setVerifyData(TRUE) to always verify the data.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: populate-webhook-data