Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Stripe Stripe
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 88
    • Issues 88
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 5
    • Merge requests 5
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Extensions
  • StripeStripe
  • Merge requests
  • !177

Make unit tests more robust

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed DaveD requested to merge DaveD/stripe:phpunit2 into master Jan 18, 2022
  • Overview 2
  • Commits 2
  • Pipelines 0
  • Changes 4

Following on from discussions in chat, @mattwire I was able to get stripe to the point where it's running and now just surfacing E_NOTICES (https://github.com/SemperIT/CiviCARROT/runs/4848384105?check_suite_focus=true#step:17:38).

The first commit is the full thing that includes some of your phpunit8 fixes you already have in another PR, but I needed in order to get past that. The total diff then removes those so is just the other changes needed, so then shouldn't conflict with your other PR. But then this PR in whole will fail tests.

FYI @KarinG

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: phpunit2