Skip to content
Snippets Groups Projects

Draft: Resolve "typo in use of null coalesce operator"

Closed Draft: Resolve "typo in use of null coalesce operator"
13-typo-in-use-of-null-coalesce-operator into master
1 unresolved thread
Closed Michael McAndrew requested to merge 13-typo-in-use-of-null-coalesce-operator into master
1 unresolved thread

Closes #13 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
CRM/Smartdebit/Base.php
93 92 $ddDetails['account_holder'] = $params['account_holder'] ?? NULL;
94 93 $ddDetails['bank_account_number'] = $params['bank_account_number'] ?? NULL;
95 94 $ddDetails['bank_identification_number'] = $params['bank_identification_number'] ?? NULL;
96 $ddDetails['bank_name'] = $params['bank_name'] ?? $ddDetails['bank_name'];
95 $ddDetails['bank_name'] = $params['bank_name'] ?? NULL;
  • mattwire
    mattwire @mattwire ·
    Maintainer
    Suggested change
    95 $ddDetails['bank_name'] = $params['bank_name'] ?? NULL;
    95 $ddDetails['bank_name'] = $params['bank_name'] ?? $ddDetails['bank_name'] ?? NULL;

    But need to check if bank_name is ever passed in via params first?

  • Please register or sign in to reply
  • mattwire closed

    closed

    • Please register or sign in to reply