Implements setExceptionMode to allow skipping the exit on exception policy
This is my suggestion to be able to call Stripe.ipn
capturing exceptions, so I can call it in a loop contest. If this is accepted here, then this could be done in the Stripe IPN API call.
That would allow automated retries of missed Stripe events, as shown in this snippet.
Thanks to @jamie for making me realize I sent yesterday this same pull request to a fork, instead of here.
Merge request reports
Activity
Hello @mattwire, I'd like to have your thoughts on this one. There are some interesting comments @jamie made in a previous pull request a made (by mistake) to a fork. Let me know how this looks to you.
Thanks!
Hi @capo something like this would be ok. However we need to ensure that we maintain the http 200 on success, http 400 on error reporting to Stripe as it uses this to verify if the webhook was correctly received/processed or not. I can't remember what throwing an exception does.
Also, variable should be named in camelCase - eg.
$exitOnException
- I know they are not consistent right now but that's historical!@capo Note that I'm planning another release of mjwshared soon (in the next week or so) - please see 0.7 branch.
Hi @mattwire,
To ensure that behaviour isn't broken, I'll leave my approach for now. Just made a new commit for changing the variable to camelCase.
Cheers
mentioned in merge request stripe!94 (closed)
changed milestone to %0.7
added enhancement label
Merged via ce6554d8 into 0.7 branch