ensure email confirm is sent for events when using stripe checkout

Fixes stripe#456 (closed)

I can try to test if this solves my problem which is a bit different, but my patch also touches this function which you've suggested to deprecate, so hopefully it would fix both!

In 3 scenarios this PR worked to solve my other problem. In one of them it looks like I used the wrong payment processor so I'll need to wait another 24 hours for the IPN.

Reporting that this PR solves my problem.

Thanks for the feedback @DaveD . What do you think @mattwire ?

@jamie @DaveD We have two places in Stripe that call setSendEmailReceipt(). This PR would stop that from working (the original intention was that you could override and ensure that no receipts were sent out eg. during an import. I think to merge this we'd need to remove use of setSendEmailReceipt() first?

@mattwire @DaveD Oh - good catch Matt. I missed the calls to setSendEmailReceipt(). That seems like useful functionality. Here's my suggestion:

1. We change MJWIPNTrait::setSendEmailReceipt - I think we should be doing a general "truthy" test (if ($sendReceipt) and set the value of is_send_receipt to either 0 or 1 depending on the result and set to NULL by default.
2. Keep MJWIPNTrait::getSendEmailReceipt - but simply return the value of is_send_receipt.

I can make this fix to the MR unless you see problems or have other suggestions.

@jamie Yes that sounds ok

added 1 commit

• 4c169525 - ensure external calls can explicitly turn off receipts

Compare with previous version

@mattwire Thanks for the feedback. I just made the changes - now, if an external program uses setSendEmailReceipt the setting should be respected, while still using "NULL" as the default value if not explicitly set.

Thanks. I've set up some tests with the patch.

This works for me

It says it needs rebase though.

added 5 commits

• 4c169525...a314b3ad - 3 commits from branch extensions:master
• 80e3d3f8 - ensure email confirm is sent for events when using stripe checkout
• 69b53f5f - ensure external calls can explicitly turn off receipts

Compare with previous version

Thanks for the feedback @DaveD, I just rebased. @mattwire I think this is ready to be merged.

added 3 commits

• 08c464b0 - 1 commit from branch extensions:master
• 5a5a43f2 - ensure email confirm is sent for events when using stripe checkout
• 9a7b23fd - ensure external calls can explicitly turn off receipts

Compare with previous version

merged

mentioned in issue #22 (closed)