Update extension min version check to use shared check name (so we don't...

Update extension min version check to use shared check name (so we don't display the same message from multiple extensions)

CRM/Mjwshared/Check.php

@@ -21,7 +21,7 @@ class CRM_Mjwshared_Check {
   /**
    * @var array
    */
-  private $messages;
+  private array $messages;
 
   /**
    * CRM_Mjwshared_Check constructor.
@@ -56,22 +56,32 @@ class CRM_Mjwshared_Check {
    * @param string $minVersion
    * @param string $actualVersion
    */
-  private function requireExtensionMinVersion($extensionName, $minVersion, $actualVersion) {
+  private function requireExtensionMinVersion(string $extensionName, string $minVersion, string $actualVersion) {
+    $actualVersionModified = $actualVersion;
     if (substr($actualVersion, -4) === '-dev') {
-      $message = new CRM_Utils_Check_Message(
-        __FUNCTION__ . $extensionName . E::SHORT_NAME . '_requirements_dev',
-        E::ts('You are using a development version of %1 extension.',
-          [1 => $extensionName]),
-        E::ts('%1: Development version', [1 => $extensionName]),
-        \Psr\Log\LogLevel::WARNING,
-        'fa-code'
-      );
-      $this->messages[] = $message;
-      $actualVersion = substr($actualVersion, 0, -4);
+      $devMessageAlreadyDefined = FALSE;
+      foreach ($this->messages as $message) {
+        if ($message->getName() === __FUNCTION__ . $extensionName . '_requirements_dev') {
+          // Another extension already generated the "Development version" message for this extension
+          $devMessageAlreadyDefined = TRUE;
+        }
+      }
+      if (!$devMessageAlreadyDefined) {
+        $message = new \CRM_Utils_Check_Message(
+          __FUNCTION__ . $extensionName . '_requirements_dev',
+          E::ts('You are using a development version of %1 extension.',
+            [1 => $extensionName]),
+          E::ts('%1: Development version', [1 => $extensionName]),
+          \Psr\Log\LogLevel::WARNING,
+          'fa-code'
+        );
+        $this->messages[] = $message;
+        $actualVersionModified = substr($actualVersion, 0, -4);
+      }
     }
 
-    if (version_compare($actualVersion, $minVersion) === -1) {
-      $message = new CRM_Utils_Check_Message(
+    if (version_compare($actualVersionModified, $minVersion) === -1) {
+      $message = new \CRM_Utils_Check_Message(
         __FUNCTION__ . $extensionName . E::SHORT_NAME . '_requirements',
         E::ts('The %1 extension requires the %2 extension version %3 or greater but your system has version %4.',
           [