Skip to content

Fix creating duplicate financial items and financial transactions

seamuslee requested to merge fix_assert_test into change_ft_financial_items_assert

I found that when we call contribution.create it will trigger recording of reversal via https://github.com/civicrm/civicrm-core/blob/master/CRM/Contribute/BAO/Contribution.php#L218 but I also found that when that is done because we don't pass in line items it uses the wrong financial type when doing the sales tax reversal so I had to add in some code to handle that and this should fix it

@monish.deb can you please review

Merge request reports