Skip to content

Use tokenProcessor to fix fatals for some tokens (and drop Smarty support)

bgm requested to merge tokenProcessor into master
  • Fixes fatal errors we were seeing with some custom tokens, where the token would not be replaced, then it would cause a smarty syntax error
  • Removes relying on a deprecated core function
  • Significative code cleanup
[warning] Deprecated function CRM_Utils_Token::replaceHookTokens, use token processor.
CRM_Core_Error::deprecatedFunctionWarning
CRM_Utils_Token::replaceHookTokens
CRM_Invoicehelper_Contribute_Form_Task_Invoice::replaceTokens
CRM_Invoicehelper_Contribute_Form_Task_Invoice::sendInvoiceEmail

cc @jofranz @Tobias_Voigt @samuelsov - fyi for the breaking change (dropping Smarty support). To be clear, I'm not against keeping Smarty support, but it felt like unnecessary work.

Merge request reports