Skip to content

Fix issue wtih non-ASCII characters in contact name not sending invoice

shaneonabike requested to merge shaneonabike/invoicehelper:master into master

I had the same issue as #2 (closed), and was able to determine that the email addresses didn't contain the proper quotes around the contact name.

They were coming out as Test Québec <test@org.org> but should actually be generated as "Test Québec" <test@org.org>. This tiny patch adds the quotes and everything is hunky dory after.

Here are two scenarios

Character issues

  1. Set an organization as Test Québec (ABC)
  2. Create Contribution pending
  3. View the Contribution and click Send Email
  4. Send the email and it will fail on validation errors

In this scenario, the email throws Validation failed for: Test Assoc Québec <someemail@example.org>. You can see how there are extra spaces. Even if I removed the brackets it still happens, and it won't work until I remove the ```é````

Extra bracket

  1. Setup an organization with test-assoc (ABC)
  2. Create Contribution pending
  3. View the contribution and click Send Email
  4. Add several recipients

The email is resolved as as <test-assoc (ABC) <someemail@example.org>

cc @bgm

Merge request reports