Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G GoCardless
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 11
    • Issues 11
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Extensions
  • GoCardless
  • Merge requests
  • !81

catch exception to allow check to complete

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Michael McAndrew requested to merge github/fork/michaelmcandrew/system-check into master May 26, 2020
  • Overview 11
  • Commits 1
  • Pipelines 0
  • Changes 1

Running cv api system.check on a site that was newly upgraded to gocardless 1.9 I got the following output:

Array
(
    [is_error] => 1
    [error_message] => Expected one OptionValue but found 0
)

Catching the exception fixes the issue for me and I now see "Missing Financial Account for GoCardless" on my status screen.

My might try an be more specific and replace Exception with CiviCRM_API3_Exception. What do you think? Happy to be guided by you on that.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/michaelmcandrew/system-check