Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G GoCardless
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 12
    • Issues 12
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Extensions
  • GoCardless
  • Merge requests
  • !46

Fix for issue 45

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Rich requested to merge issue/45 into master Dec 18, 2018
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: artfulrobot

Assumed input params to be strings and comparing with == but the membership forms include nested arrays with numeric keys. Since 'some string' evaluates to 0, 0 == 'some string' and the first string tested was first name, so that got clobbered. Using === instead has solved this.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: issue/45