Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • F form-processor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 15
    • Issues 15
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Extensions
  • form-processor
  • Merge requests
  • !38

improve Boolean validation and normalization

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged JonGold requested to merge JonGold/form-processor:boolean-improved into master Jun 09, 2022
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 2

This corrects issues with the Boolean improvements introduced in 1.36. Existing Form Processor instances would not have been affected by these bugs unless they attempted to use the new features introduced in 1.36.

  • I reverted the validateValue() changes in !37 (merged). Validation is, of course, on the raw values, and is unaffected by how this class returns the value from doAction().
  • Testing showed that passing a lowercase y or t was not resolving to TRUE.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: boolean-improved