Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • F form-processor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 16
    • Issues 16
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Extensions
  • form-processor
  • Merge requests
  • !29

Fixes !27: Validate FormProcessorAction mappings on save.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged JonGold requested to merge JonGold/form-processor:validatemappings into master Sep 03, 2021
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

Issue !27 (merged) is actually two separate bugs, but they're closely related - they both occur because when we save a FormProcessorAction, we don't check the validity of the mapping. If we delete a custom field referenced in the mapping, we must also delete it from the mapping array. Likewise, if we delete an input that is referenced in the mapping, we must remove it from the mapping. I've introduced a FormProcessorAction mapping validation method, which can be expanded if other invalid mapping permutations arise.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: validatemappings